Skip to content
This repository was archived by the owner on Apr 5, 2022. It is now read-only.

Conversation

eddumelendez
Copy link

Fixes gh-207

@habuma
Copy link
Contributor

habuma commented Oct 12, 2016

I appreciate the help on migrating to Thymeleaf 3. For the time being, however, I'm going to follow Spring Boot's lead on this and stick with 2.1.5. When Spring Boot's dependencies shift to Thymeleaf 3, then I'll follow suit and merge this PR.

Also, if you've not yet signed the individual contributor agreement (https://cla.pivotal.io/), please do. It'd be greatly helpful for me when the time comes to merge. Thanks

@habuma
Copy link
Contributor

habuma commented Oct 12, 2016

Closing PR and then will immediately reopen, in hopes of triggering Travis CI.

@habuma habuma closed this Oct 12, 2016
@habuma habuma reopened this Oct 12, 2016
@alek-sys
Copy link

Hi @habuma
What do you think about the idea to extract Thymeleaf support (including dialect) from spring-social-web into a separate package spring-social-web-thymeleaf? It can be then split to thymeleaf2 / thymeleaf3 versions with dependencies on different TL versions.

It has few advantages, actually:

  1. It will be possible to create spring-social-web-thymeleaf2 and spring-social-web-thymeleaf3 now (based on @eddumelendez changes) and let people switch to version 3 if needed
  2. spring-social-web will still use spring-social-web-thymeleaf2, so this is 100% backward compatible
  3. It removes a direct dependency from spring-social-web to Thymeleaf. This will help people who don't use Thymeleaf but sill want to use Spring Social.
  4. When Spring Boot will switch to TL 3 by default, the only change for Spring-Social will be dependency update from spring-social-web-thymeleaf2 to spring-social-web-thymeleaf3.

If that sounds reasonable I can help with a pull request, I guess.

@wilkinsona
Copy link
Contributor

Spring Boot 2.0 is going to upgrade to Thymeleaf 3

@theandrewlane
Copy link

Please merge :)

@habuma
Copy link
Contributor

habuma commented Jan 19, 2017

Rather than merge this PR directly, I've extracted the existing Thymeleaf 2 support into a separate module (as suggested by @alek-sys; thanks @alek-sys !) and create a new Thymeleaf 3 module with (most of) the changes from @eddumelendez. I had to change a few things, however, because it seems that the IContext passed around in ConnectedAttrProcessor cannot be cast to a Spring ApplicationContext, although it can be used to get the Spring ApplicationContext.

@habuma habuma closed this Jan 19, 2017
@alek-sys
Copy link

Awesome, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants