Review documentation [SWS-120]

[gregturn]

Arjen Poutsma opened SWS-120 and commented

It would be nice if a native speaker could review the written documentation before 1.0 final.

---

Affects: 1.0 RC1

Attachments:

• spring-ws-reference-1.0-RC1-pc.pdf (394.56 kB)

Referenced from: commits 1ffa706

[gregturn]

Corba the Geek commented

The latest chapters are a great addition. In the process of reading through chapters 2 through 5, I've added notes to the latest .pdf file about misspellings, grammatical errors and usage suggestions.

[gregturn]

Rick Evans commented

Hi Corba

Thanks for taking the time to annotate the documentation with comments and stuff, it is really appreciated... I am in the process of folding your edits into the source documents.

Cheers
Rick

[gregturn]

Rick Evans commented

Fixed.

Thanks for taking the time to annotate the documentation with the corrections; nice work.

I have corrected all of the errors that you pointed out, and I have put markers in place to handle some of the bigger issues you pointed out (like add an appendix).

One of your comments in the annotated document was about the favouring of constructor-injection over setter-injection in the examples.

I'll refer you to the main Spring reference documentation for the answer. If you click on this link and scroll a little (half a page or so) down, you will see a sidebar entitled 'Constructor- or Setter-based DI?', which explains the Spring teams view (not unanimous it must be added) about this topic.

http://static.springframework.org/spring/docs/2.0.x/reference/beans.html#beans-factory-collaborators

Hope that helps.

Cheers
Rick

[gregturn]

Arjen Poutsma commented

Closing 1.0 RC2 issues.