WebServiceTemplate hasFaut skips check for fault in response if the connection implements FaultAwareWebServiceConnection [SWS-137]

[gregturn]

Pablo Depietri opened SWS-137 and commented

The method should check for a fault in the connection and then in the response as follows:

protected boolean hasFault(WebServiceConnection connection, WebServiceMessage response) throws IOException {
if (connection instanceof FaultAwareWebServiceConnection) {
if (((FaultAwareWebServiceConnection) connection).hasFault())
return true;
}
return response.hasFault();
}

---

Affects: 1.0 RC1

Issue Links:

• WebServiceTemplate hasFaut skips check for fault in response if the connection implements FaultAwareWebServiceConnection [SWS-330] #484 WebServiceTemplate hasFaut skips check for fault in response if the connection implements FaultAwareWebServiceConnection

Referenced from: commits 06cc637

[gregturn]

Arjen Poutsma commented

Are you experiencing problems with the way it currently works? The current way is more suitable for streaming access of the response message. In the way suggested, you have to fully parse the response message in the positive case (i.e. no fault), which is too expensive. What I can imagine is something like:

protected boolean hasFault(WebServiceConnection connection, WebServiceMessage response) throws IOException {
if (!((FaultAwareWebServiceConnection) connection).hasFault())
return false;
}
return response.hasFault();
}

This way, we double check whether the connection fault really is a fault.

The hasFault() means (in HTTP terms) an error 500, in accordance with the WS-I spec. If a server sends a fault without a 500, it is not interoperable. And it's not just HTTP, JMS has a similar mechanism (a boolean property).

[gregturn]

Pablo Depietri commented

I am connecting to a 3rd party HTTP server that is returning a fault without an error 500. Since I have no control over the server, I will extend
WebServiceTemplate and override hasFault() as I had previously suggested.

Thanks for the quick reply!

[gregturn]

Arjen Poutsma commented

I could also add a property to the template: "checkConnectionForFault", which by default is true, but you can set to false, so that you don't have to override the method.

[gregturn]

Arjen Poutsma commented

I've added the checkConnectionForFault property to the WebServiceTemplate to with Web services which are not WS-I compliant.

[gregturn]

Arjen Poutsma commented

Closing 1.0 RC2 issues.