Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Web Services does not seem to work with Castor 1.2 [SWS-287] #444

Closed
gregturn opened this issue Feb 16, 2008 · 10 comments
Closed

Spring Web Services does not seem to work with Castor 1.2 [SWS-287] #444

gregturn opened this issue Feb 16, 2008 · 10 comments
Assignees
Milestone

Comments

@gregturn
Copy link
Member

@gregturn gregturn commented Feb 16, 2008

Jim Cummings opened SWS-287 and commented

As brought up in the forum at http://forum.springframework.org/showthread.php?t=49583, it looks like as of Castor 1.2, castor has changed the way their XMLClassDescriptorResolver behaves that is incompatible with the way CastorMarshaller.java is using it.

While loading the spring config you'll get the following exception:

Caused by: java.lang.NullPointerException
at org.exolab.castor.xml.util.XMLClassDescriptorResolverImpl.setMappingLoader(XMLClassDescriptorResolverImpl.java:143)
at org.springframework.oxm.castor.CastorMarshaller.createClassDescriptorResolver(CastorMarshaller.java:325)
...

I think spring-ws's CastorMarshaller may need to change to use Castor's XMLContext instead of the resolver directly and when creating castor's Marshaller/Unmarshaller. I was able to do this with local changes and it works fine, but that would probably break pre-1.2 Castor so the real framework change would likely involve a bit more.


Affects: 1.0.3

Attachments:

Issue Links:

  • #465 Add namespaceMappings property to CastorMarshaller
    ("is depended on by")

Referenced from: commits f61e401

7 votes, 7 watchers

@gregturn
Copy link
Member Author

@gregturn gregturn commented Feb 16, 2008

Arjen Poutsma commented

Could you please supply the local changes you made as a patch? Thanks.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Feb 18, 2008

Jim Cummings commented

Arjen - here are the local changes I had made in case it is useful. This passes the spring-ws tests and worked for my problem at hand as well.

The supports() method clearly isn't as smart now. I'm hoping the various class loading scenarios would work with this, but I'm not confident since going with XMLContext seems to limit your control over the class loaders a bit.

Also, this does break pre-castor 1.2 as well.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Mar 5, 2008

Erik-Berndt Scheper commented

I've verified that the supplied patch works fine for me, too.

@gregturn
Copy link
Member Author

@gregturn gregturn commented Mar 6, 2008

jang commented

I had the same problem and this patch works good.
Will it be implemented in Spring web services 1.5 ?????

@gregturn
Copy link
Member Author

@gregturn gregturn commented Mar 11, 2008

Erik-Berndt Scheper commented

See #465 for another improvement on the CastorMarshaller class.

@gregturn
Copy link
Member Author

@gregturn gregturn commented May 2, 2008

Arjen Poutsma commented

After doing some research, I have come to the conclusion that it is impossible to support both Castor 1.1.1- and 1.1.2+ with the same marshaller. I tried various reflection tricks, but it seems impossible to differentiate between the different Castor versions. The fact that XMLContext was introduced in 1.1.2 doesn't really help here, since that means it's not a 1.1 vs. 1.2 differentiator.

So, I think the way forward is to support Castor 1.2+ only. It's really a shame that Castor broke the existing behavior with a minor version upgrade, thus forcing us into this.

@gregturn
Copy link
Member Author

@gregturn gregturn commented May 2, 2008

Arjen Poutsma commented

Resolved, though this means that the CastorMarshaller only works with 1.2+.

@gregturn
Copy link
Member Author

@gregturn gregturn commented May 4, 2008

Werner Guttmann commented

Arjen, being a committer of Castor, I'd like to know what the issue is ?

@gregturn
Copy link
Member Author

@gregturn gregturn commented May 5, 2008

Arjen Poutsma commented

Closing issues for 1.5.1

@gregturn
Copy link
Member Author

@gregturn gregturn commented May 30, 2008

Vyas Sanzgiri commented

I am still experiencing the same issue with 1.5.2 and castor 1.2. Is this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.