Skip to content

does not support other configuration options than url #3087

@hanspagel

Description

@hanspagel

Describe the bug

When using the Scalar integration, the configuration is mostly ignored (except url, enabled and path). I think it’s because we’re extending the controller and not generating the configuration properly:

v2.8.12...v2.8.13#diff-ce96e9c890a768b5beebf308a37b6118b4e4cb61419e103c7be95e8926b6750eR93-R97

Maybe we can fix with the recent version of the webjar?

scalar/scalar#6783

Or, maybe we can get rid of the controller and fix the issues you had upstream.

Wdyt?

To Reproduce
Steps to reproduce the behavior:

  • Install springdoc-openapi-starter-webmvc-scalar
  • Set scalar.theme=purple
  • Check /scalar to see that the configuration does not have the theme key:
Scalar.createApiReference('#app',     {
  url: "http://localhost:8080/v3/api-docs"
  // this should have `theme: 'purple'` here
})

Expected behavior

All configuration options are accessible when using springdoc-openapi-starter-webmvc-scalar

Ideally, they'd be always in sync with the upstream package (and we don’t override the controller anymore?)

Additional context

THANKS FOR ADDING SCALAR, I’m so excited to see it here

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions