ApiResponse DEFAULT_DESCRIPTION Improvement

[raghuraman1]

Hi @bnasslahsen

Remember below code in ControllerAdvice

Look at the corresponding responses:

Expectation is that instead of "defaultResponse" it should pickup the message from HttpStatus.getReasonPhrase().

Raghu

[raghuraman1]

@bnasslahsen The Travis test failed for related PR #611 and I presume thats a good thing. The related tests will need changing. The change I did probably went beyond ControllerAdvices. Basically instead of "defaultResponse" I am trying to make it work using HttpStatus.getReasonPhrase(). Sounds reasonable to me.

[bnasslahsen]

@raghuraman1,

Ok, i will see the impacts on the tests.
The improvement you propose, is not only related to the controllerAdvice.

[raghuraman1]

Agreed. I was just writing that its beyond ControlerAdvice.

[raghuraman1]

@bnasslahsen I can fix the tests as part of the PR

[bnasslahsen]

@raghuraman1,

It's ok. I have already started the merge.

[raghuraman1]

I just noticed what you typed. Was committing the test changes

[raghuraman1]

@bnasslahsen I do wish I could have some PR committed in my name also. :)
Some day will happen I guess.
But you are fast and gud.

[bnasslahsen]

@raghuraman1,

Next time 👍

[raghuraman1]

@bnasslahsen This time it was like a robbery from my point of view. :)
But you guys are making a great product.
Meanwhile Eagerly waiting for next release. We have lots of fixes to be released.