Skip to content

Generate a default tag name if no tag specified #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Generate a default tag name if no tag specified #175

merged 1 commit into from
Nov 21, 2019

Conversation

hisener
Copy link
Contributor

@hisener hisener commented Nov 21, 2019

Relates to #173

One of the nice features of Springfox is that it generates default tags. So that we can see endpoints grouped by controller name. It is handy for applications with a bunch of controllers. I think springdoc should also provide a default tag name. WDYT?

Please note that I haven't fixed all of the tests.


List<io.swagger.v3.oas.annotations.tags.Tag> allTags = new ArrayList<>();
List<Tag> allTags = new ArrayList<>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrelated to the change but unnecessary qualification.

@springdoc springdoc merged commit 248ddb6 into springdoc:master Nov 21, 2019
springdoc pushed a commit that referenced this pull request Nov 21, 2019
@chadmalla-unity
Copy link

Hi @hisener is the purpose of this PR to have a default tag name to be the controller name without annotating the controller with@Tag? Thank you for the PR btw!

@chadmalla-unity
Copy link

Never mind just tried with version 1.2.10 and doing exactly what I wanted in my original issue. Thanks!

@hisener hisener deleted the hsener/generate-default-tag branch November 23, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants