Skip to content

refactor(core): Use ObjectMapperFactory to create ObjectMapper instead of new instance #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2,721 commits into from
Closed

refactor(core): Use ObjectMapperFactory to create ObjectMapper instead of new instance #2983

wants to merge 2,721 commits into from

Conversation

Ahoo-Wang
Copy link

@Ahoo-Wang Ahoo-Wang commented May 7, 2025 •
edited
Loading

  • Use ObjectMapperFactory to create ObjectMapper instead of new instance （Prevent additionalProperties deserialization exception）
  • Check OpenAPI specification version and use appropriate ObjectMapper
  • This change ensures proper deserialization for both 3.0 and 3.1 specifications
2025-05-07T15:09:27.656+08:00  WARN 43847 --- [x-service] [r-http-kqueue-3] o.springdoc.core.service.OpenAPIService  : Json Processing Exception occurred: additionalProperties must be either a Boolean or a Schema instance
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1, column: 1228667] (through reference chain: io.swagger.v3.oas.models.OpenAPI["components"]->io.swagger.v3.oas.models.Components["schemas"]->java.util.LinkedHashMap["prajna.StringStringMap"]->io.swagger.v3.oas.models.media.Schema["additionalProperties"])

bnasslahsen and others added 30 commits September 17, 2024 19:47
@bnasslahsen
Merge branch 'dgswan-bugfix/T-2509-fix-array-index-out-of-bounds-exce…
a6772c3 
…ption-in-swagger-ui-config-parameters'
@bnasslahsen
Merge branch 'bugfix/T-2442-fix-springdoc-app193-test-for-java21-and-…
39e15fe 
…above' of https://github.com/dgswan/springdoc-openapi into dgswan-bugfix/T-2442-fix-springdoc-app193-test-for-java21-and-above
@bnasslahsen
fix groovy tests
4c002e5
@bnasslahsen
Merge branch 'dgswan-bugfix/T-2442-fix-springdoc-app193-test-for-java…
1208e38 
…21-and-above'
@bnasslahsen
Merge branch 'fix-default-media-type' of https://github.com/limehee/s…
ae5ab58 
…pringdoc-openapi into limehee-fix-default-media-type
@bnasslahsen
Merge branch 'limehee-fix-default-media-type'
b8d3453
@bnasslahsen
Merge branch 'bugfix/2275-missing-description-kotlin' of https://gith…
db32192 
…ub.com/GeorgEchterling/springdoc-openapi into GeorgEchterling-bugfix/2275-missing-description-kotlin
@bnasslahsen
Merge branch 'GeorgEchterling-bugfix/2275-missing-description-kotlin'
b3e965e
@bnasslahsen
Fix tests for 21.0.4
feb7f6c
@bnasslahsen
Boolean Parameter with @Schema Annotation Changes Type to string in O…
1fc8f9d 
…penAPI Documentation Fixes springdoc#2638
@bnasslahsen
@JsonUnwrapped is ignored when PolymorphicConverter is enabled. Fixes s…
7bb5fc2 
…pringdoc#2640
@bnasslahsen
UpperSnakeCaseStrategy is not working with spring boot and ParameterO…
2b45ea4 
…bject. Fixes springdoc#2643
@bnasslahsen
swagger-core upgrade to 2.2.23
68be64e
@bnasslahsen
The operationId is unnecessarily deduplicated for a requestBody with …
cdbd7f6 
…multiple content types. Fixes springdoc#2646.
@bnasslahsen
Add support for OAS v3.1 webhooks. Fixes springdoc#2657
42f2c84
@bnasslahsen
Content definition in @apiresponse remove schema generated based on t…
5e42cf5 
…he returned value. Fixes springdoc#2663
@bnasslahsen
Calling Swagger UI via different context paths fails. Fixes springdoc…
0d7dc37 
…#2642
@bnasslahsen
swagger-core upgrade to version: 2.2.24
829e4b6
@bnasslahsen
Annotation @hidden on rest controller class level doesn't work due to…
7a4d09e 
… spring default proxying mechanism CGLIB. Fxies springdoc#2709
@bnasslahsen
Calling Swagger UI via different context paths fails. Fixes springdoc…
03349cf 
…#2642
@granddaifuku
Display nullable request body with map type. Fixes springdoc#2703
ad86c0a
@bnasslahsen
code review
3237787
@bnasslahsen
Merge branch 'granddaifuku-fix/2703-display-request-body-with-nullabl…
0287e83 
…e-map-type'
@bnasslahsen
fix test
1f128e8
@bnasslahsen
improving actuator docs
1a9a1d4
@bnasslahsen
Keeping ActuatorOpenApiCustomizer for backward compatibility
c24e9e7
@bnasslahsen
javadoc update
96324c0
@bnasslahsen
failed to load api definition after spring boot 3.4.0-M2. Fixes sprin…
b0a8b77 
…gdoc#2687
@kamilkrzywanski
issue springdoc#2733
7af3552
@bnasslahsen
Improve performance tests
d502af2
bnasslahsen and others added 28 commits March 27, 2025 18:07
@bnasslahsen
Don't include the whole Spring Boot parent in your springdoc-openapi …
214cba6 
…pom. Fixes springdoc#2944
@bnasslahsen
swagger-ui upgrade to 5.20.6
aeb5f51
@bnasslahsen
NPE when customizing group's open-api without specifying any schema. F…
493125c 
…ixes springdoc#2960
@bnasslahsen
swagger-ui update to version 5.20.7
c92f581
@lagoshny
ISSUE-2969 fix path to register resource handler to work SwaggerIndex…
5220195 
…PageTransformer considering /webjar path prefix
@lagoshny
ISSUE-2969 fix path to register resource handler to work SwaggerIndex…
a39ce4f 
…PageTransformer considering /webjar path prefix
@lagoshny
ISSUE-2969 fix path to register resource handler to work SwaggerIndex…
6c3ac25 
…PageTransformer considering /webjar path prefix - add test
@bnasslahsen
swagger-core update to 2.2.30
ba51c98
@bnasslahsen
swagger-ui update to version 5.21.0
367f1c6
@bnasslahsen
Merge pull request springdoc#2970 from lagoshny/ISSUE-2969
b057b2a 
ISSUE-2969 fix path to register resource handler to work SwaggerIndexPageTransformer considering /webjar path prefix
@bnasslahsen
spring-boot upgrade to 3.4.5
da85bc2
@bnasslahsen
Merge branch 'fix/kotlin' of github.com:mymx2/springdoc-openapi into …
aee7cc2 
…mymx2-fix/kotlin
@bnasslahsen
code review
17cd6b2
@bnasslahsen
Merge branch 'mymx2-fix/kotlin'
216fab6
@bnasslahsen
Set default content type for problem details object to application/pr…
0cd571a 
…oblem+json. Fixes springdoc#2963
@bnasslahsen
Cannot add custom description and example for java.time.Duration sinc…
752bfec 
…e v2.8.6. Fixes springdoc#2964.
@bnasslahsen
Build Failure due to Private Inner Class. Fixes springdoc#2976, sprin…
3d056d8 
…gdoc#2967
@bnasslahsen
Regression: @Header(schema = @Schema(type = "string")) generates empt…
95fa3bb 
…y or broken schema in OpenAPI output since 2.8.0. Fixes springdoc#2972
@bnasslahsen
List of value classes in Kotlin. Fixes springdoc#2971
a68b42e
@bnasslahsen
pom.xml cleanup for springdoc#2944
9dffa3d
@bnasslahsen
pom.xml cleanup for springdoc#2944
5eb7d77
@bnasslahsen
Prepare for the next release
98dacbd
[maven-release-plugin] prepare release v2.8.7
764ef2f
[maven-release-plugin] prepare for next development iteration
7a3546c
@bnasslahsen
Handle projects not using kotlin-reflect. Fixes springdoc#2977
707fce0
[maven-release-plugin] prepare release v2.8.8
bce44db
[maven-release-plugin] prepare for next development iteration
a886363
@Ahoo-Wang
refactor(core): Use ObjectMapperFactory to create ObjectMapper instea…
74394a8 
…d of new instance

- Use ObjectMapperFactory to create ObjectMapper instead of new instance （Prevent `additionalProperties` deserialization exception）
- Check OpenAPI specification version and use appropriate ObjectMapper
- This change ensures proper deserialization for both 3.0 and 3.1 specifications

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.