Upgrade swagger-core to version 2.2.38 #3105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Instant timestamp; | ||
|
|
||
| @Schema(name = "value", type = "number", format = "double", description = "The data value", required = true, example = "19.0") | ||
| @Schema(name = "value", types = "number", format = "double", description = "The data value", required = true, example = "19.0") |
There was a problem hiding this comment.
If type = "number" is provided, then the schema type is incorrectly assigned as string.
If the type is omitted, it is resolved to number.
With types = "number", it is also still number.
With some other type, e.g., types = "object", then the type is resolved to "type" : [ "number", "object" ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades swagger-core from 2.2.36 to 2.2.38.
Note that the schema type overriding for the 3.1 specification resolver seems to have had some minor regression, as it now seems to require the 3.1
typesto be set rather than the old 3.0type. This has previously been highlighted as issues by consumers, so might be necessary to investigate if a fallback is possible.This should also close swagger-api/swagger-core#4822, since the duplicated
oneOfissue seems to have been resolved.