Chore/abstract business logic #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing was getting harder, more complex and more verbose as we added more functionality. Not least because testing business logic in React components (with
enzyme
et al.) is very clunky to begin with. So, it was decided that all of the business logic could be described by a simple ES6 class (the 'store') rather than a React component, and that React components (the context Providers/Consumers) could simply be gateways/APIs to instances of the 'store'.Changes:
AccordionContainer.spec
(now calledAccordionContext.spec
) and rewrites them intoAccordionStore.spec
.AccordionContext
to assert it's relationship withAccordionStore
.Implications
It should now be much simpler to maintain business logic rules in RAA, because they can all be described by a single class. Making the API changes necessary for v3.0 will now be trivial. Incidentally, we could even unblock server-side-rendering issues now, by exposing an
isItemExpanded
method in AccordionStore.