Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand fulfillment login e2e tests #318

Merged

Conversation

aleespryker
Copy link
Contributor

@aleespryker aleespryker commented May 3, 2023

Closes HRZ-2826

Copy link
Contributor

@AndreyYevtukhov AndreyYevtukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, clean and small, I like these tests)
Left some small comments)

gund
gund previously approved these changes May 4, 2023
Base automatically changed from feature/hrz-2821-style-fulfillment-login-page to development May 5, 2023 14:32
…ature/hrz-2826-update-fulfillment-login-e2e-tests
@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for dev-composable-storefront-labs ready!

Name Link
🔨 Latest commit c70a840
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront-labs/deploys/64620c299e9a4d00086337d3
😎 Deploy Preview https://deploy-preview-318--dev-composable-storefront-labs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit c70a840
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/64620c2802b0e80008e73af8
😎 Deploy Preview https://deploy-preview-318--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit c70a840
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/64620c286e14e2000888db6c
😎 Deploy Preview https://deploy-preview-318--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit c70a840
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/64620c28a8b55a000824c73d
😎 Deploy Preview https://deploy-preview-318--dev-composable-storefront.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

AndreyYevtukhov
AndreyYevtukhov previously approved these changes May 5, 2023
* fix: populate DB data before redirecting from loading screen

* fix: only populate offline data once
libs/domain/picking/offline/data-plugin.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@AndreyYevtukhov AndreyYevtukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aleespryker aleespryker merged commit 8d654be into development May 15, 2023
@aleespryker aleespryker deleted the feature/hrz-2826-update-fulfillment-login-e2e-tests branch May 15, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants