Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: populate DB data before redirecting from loading screen #320

Conversation

aleespryker
Copy link
Contributor

@aleespryker aleespryker commented May 4, 2023

Closes HRZ-2869

Copy link
Contributor

@Sinucid Sinucid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes 2 similar requests to the BAPI at once. And till the second one is resolved it shows not found screen

Screenshot 2023-05-05 at 09 58 09

Screenshot 2023-05-05 at 09 58 16

@Sinucid Sinucid self-requested a review May 5, 2023 15:13
@aleespryker aleespryker merged commit 80183fb into feature/hrz-2826-update-fulfillment-login-e2e-tests May 5, 2023
@aleespryker aleespryker deleted the bugfix/hrz-2869-loading-screen-wait-for-picking-lists branch May 5, 2023 16:07
aleespryker added a commit that referenced this pull request May 15, 2023
* fix: use content-type application/vnd.api+json

* feat: style fulfillment login page

* fix: fix stylelint errors

* fix: fix stylelint

* fix: fix e2e tests

* fix: remove unneeded heading

* fix: refactoring

* fix: refactoring

* fix: refactoring

* fix: use new screenCss format

* fix: add missing spacing

* feat: expand fulfillment login e2e tests

* fix: wait for loading page

* fix: clean up styles in components with inputs

* fix: refactoring

* fix: remove css e2e test

* fix: other e2e tests

* fix: populate DB data before redirecting from loading screen (#320)

* fix: populate DB data before redirecting from loading screen

* fix: only populate offline data once

* fix: refactoring

* fix: e2e tests

* fix: fix intercept order

* fix: more efficient data plugin observable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants