Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(experience): left refs identifier for experience data \ update layout wrappers #958

Merged
merged 4 commits into from
Dec 7, 2023
Merged

feat(experience): left refs identifier for experience data \ update layout wrappers #958

merged 4 commits into from
Dec 7, 2023

Conversation

supproduction
Copy link
Contributor

@supproduction supproduction commented Nov 30, 2023 •
edited by jira bot
Loading

closes HRZ-90625

@supproduction supproduction requested a review from a team as a code owner November 30, 2023 12:00
@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited
Loading

✅ Deploy Preview for dev-fulfillment canceled.

Name Link
🔨 Latest commit c0a92c9
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/6571daf6a997d800085985f2

@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited
Loading

✅ Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit c0a92c9
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/6571daf6ff8ee800082bcde3
😎 Deploy Preview https://deploy-preview-958--dev-composable-storefront.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 3 paths audited
Performance: 39 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 97 (no change from production)
SEO: 87 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited
Loading

✅ Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit c0a92c9
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/6571daf6df5fd80008aca3c2
😎 Deploy Preview https://deploy-preview-958--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Nov 30, 2023 •
edited
Loading

Passing run #11728 ↗︎

0 55 55 0 Flakiness 0

Details:

feat: adjust layout plugin wrappers (#974)
Project: Composable Storefront Commit: c0a92c9a8e
Status: Passed Duration: 03:20 💡
Started: Dec 7, 2023 2:51 PM Ended: Dec 7, 2023 2:54 PM

Review all test suite changes for PR #958 ↗︎

@supproduction supproduction changed the title feat: left refs identifier for experience data [WIP] feat: left refs identifier for experience data Nov 30, 2023
@supproduction supproduction changed the title [WIP] feat: left refs identifier for experience data feat: left refs identifier for experience data \ update layout wrappers Dec 7, 2023
@supproduction supproduction changed the title feat: left refs identifier for experience data \ update layout wrappers feat(experience): left refs identifier for experience data \ update layout wrappers Dec 7, 2023
@supproduction supproduction merged commit 0ef0d94 into development Dec 7, 2023
37 of 39 checks passed
@supproduction supproduction deleted the feature/hrz-90625-improve-refs branch December 7, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobi-or-not-tobi tobi-or-not-tobi tobi-or-not-tobi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supproduction @tobi-or-not-tobi