Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ref saving #970

Merged
merged 9 commits into from
Dec 7, 2023
Merged

feat: ref saving #970

merged 9 commits into from
Dec 7, 2023

Conversation

supproduction
Copy link
Contributor

@supproduction supproduction commented Dec 6, 2023 •
edited by jira bot
Loading

closes HRZ-90673

@supproduction supproduction requested a review from a team as a code owner December 6, 2023 15:53
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited
Loading

✅ Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit eaeb245
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/6570f204c9da4100083d57e8
😎 Deploy Preview https://deploy-preview-970--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited
Loading

✅ Deploy Preview for dev-fulfillment canceled.

Name Link
🔨 Latest commit eaeb245
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/6570f204f34806000899a7ca

@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited
Loading

✅ Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit eaeb245
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/6570f2042d398100080a7b80
😎 Deploy Preview https://deploy-preview-970--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 3 paths audited
Performance: 31 (🔴 down 7 from production)
Accessibility: 90 (no change from production)
Best Practices: 97 (no change from production)
SEO: 87 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Dec 6, 2023 •
edited
Loading

1 flaky test on run #11723 ↗︎

0 55 55 0 Flakiness 1

Details:

fix
Project: Composable Storefront Commit: a554eb75f2
Status: Passed Duration: 03:15 💡
Started: Dec 7, 2023 12:01 PM Ended: Dec 7, 2023 12:04 PM
Flakiness  src/integration/checkout-addresses.cy.ts • 1 flaky test • sf-regression

View Output Video

Test Artifacts
... > should show shipping address form if user does not have addresses (authenticated) Test Replay Screenshots Video

Review all test suite changes for PR #970 ↗︎

@supproduction supproduction changed the base branch from development to feature/hrz-90625-improve-refs December 6, 2023 22:15
@supproduction supproduction changed the base branch from feature/hrz-90625-improve-refs to development December 7, 2023 09:08
@supproduction supproduction changed the base branch from development to feature/hrz-90625-improve-refs December 7, 2023 09:08
@supproduction supproduction merged commit 31fa3fb into feature/hrz-90625-improve-refs Dec 7, 2023
22 of 23 checks passed
@supproduction supproduction deleted the feature/hrz-90673-ref-saving branch December 7, 2023 13:05
@cypress cypress bot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobi-or-not-tobi tobi-or-not-tobi tobi-or-not-tobi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supproduction @tobi-or-not-tobi