-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix a bug when introducing commands in normal mode #87
Conversation
Thank you for your contribution. Don't worry about failed test. The failure in our tests seems unrelated to this. I leaved a simple code suggestion. |
Where is your suggestion? Sorry if I misunderstood. |
I'm sorry. I forgot submitting the suggestion. |
Thank you for your suggestion. It looked totally better, so I adopted it. |
Great!
I don't think that's a good idea because we don't know if it breaks the test suite somehow. So, it's better to fix it first and then ask @ryohei22 to merge with |
@ryohei22, please rebase this one as well. |
Co-authored-by: ok97465 <ok97465@gmail.com>
Merging according to @ok97465's feedback. |
Description of the change
I fixed a bug.
Steps to occur the bug
In the NORMAL mode of Vim, when you only type ":", the Issue reporter shows up.