Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix a bug when introducing commands in normal mode #87

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

ryohei22
Copy link
Contributor

@ryohei22 ryohei22 commented Jul 8, 2023

Description of the change

I fixed a bug.

Steps to occur the bug

In the NORMAL mode of Vim, when you only type ":", the Issue reporter shows up.

@ryohei22 ryohei22 changed the title Fix a bug PR: Fix a bug Jul 9, 2023
@ok97465
Copy link
Collaborator

ok97465 commented Jul 9, 2023

Thank you for your contribution.

Don't worry about failed test. The failure in our tests seems unrelated to this.

I leaved a simple code suggestion.

@ryohei22
Copy link
Contributor Author

ryohei22 commented Jul 9, 2023

I leaved a simple code suggestion.

Where is your suggestion? Sorry if I misunderstood.

@ok97465
Copy link
Collaborator

ok97465 commented Jul 10, 2023

I leaved a simple code suggestion.

Where is your suggestion? Sorry if I misunderstood.

I'm sorry. I forgot submitting the suggestion.

@ryohei22
Copy link
Contributor Author

Thank you for your suggestion. It looked totally better, so I adopted it.

@ccordoba12 ccordoba12 added this to the v0.2.0 milestone Jul 10, 2023
@ccordoba12 ccordoba12 changed the title PR: Fix a bug PR: Fix a bug when introducing commands in normal mode Jul 10, 2023
@ccordoba12
Copy link
Member

It seems we need to fix our tests first, as @ok97465 mentioned.

@ok97465, do you have time to take a look at that?

@ok97465
Copy link
Collaborator

ok97465 commented Jul 10, 2023

It seems we need to fix our tests first, as @ok97465 mentioned.

@ok97465, do you have time to take a look at that?

Yes, I will do this weekend.

Can we merge this PR before fixing the test?

@ccordoba12
Copy link
Member

ccordoba12 commented Jul 11, 2023

Yes, I will do this weekend.

Great!

Can we merge this PR before fixing the test?

I don't think that's a good idea because we don't know if it breaks the test suite somehow. So, it's better to fix it first and then ask @ryohei22 to merge with master afterwards.

@ccordoba12
Copy link
Member

@ryohei22, please rebase this one as well.

ryohei22 and others added 2 commits July 13, 2023 01:42
Co-authored-by: ok97465 <ok97465@gmail.com>
@ccordoba12
Copy link
Member

Merging according to @ok97465's feedback.

@ccordoba12 ccordoba12 merged commit 561107a into spyder-ide:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants