Drop onlineUtils and commands from DB2 keywords #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added in 57d50ec
These multi-word things don't really fit to keyword list. Making the keywords list of DB2 quite different from keywords list of other dialects. I have no idea whether these were added to solve some issue in DB2 formatting or not as there are no tests for this. Some of these are clearly incorrect like
MODIFY admtproc,APPL=SHUTDOWN.Unless there's some known problem with DB2 formatting that these "keywords" fix, I think we're better off without them, as for now they just cause confusion.