Clean Makefile #189
Clean Makefile #189
Conversation
|
Seems like it's failing in travis ci? |
|
Yes sorry, there's a variable scope problem. I'll fix this tomorrow morning. |
|
Currently |
|
Switching from coffeescript to JavaScript if not necessarily a bad idea, but if you want to do so, then you have to rewrite the API code as idiomatic js, you can't leave the generated files like that |
|
From https://travis-ci.org/kripken/sql.js/builds/207117119, one test passes, on Node 0.10, the others fail at Reading Blob. |
|
Travis also indicates a warning message in the tests
|
js/api.js
Outdated
|
|
||
| Module['onRuntimeInitialized'] = function() { | ||
| // Generated by CoffeeScript 1.12.4 | ||
| console.log('ok') |
There was a problem hiding this comment.
Why did you add a console.log ? Libraries should have undocumented side-effects, like writing to the console.
There was a problem hiding this comment.
Omission, sorry. Removed in latest commit.
| size = sqlite3_column_bytes(this.stmt, pos); | ||
| ptr = sqlite3_column_blob(this.stmt, pos); | ||
| result = new Uint8Array(size); | ||
| for (i = k = 0, ref = size; 0 <= ref ? k < ref : k > ref; i = 0 <= ref ? ++k : --k) { |
| this['bind'](params) && this['step'](); | ||
| } | ||
| results1 = []; | ||
| for (field = k = 0, ref = sqlite3_data_count(this.stmt); 0 <= ref ? k < ref : k > ref; field = 0 <= ref ? ++k : --k) { |
| Statement.prototype['getColumnNames'] = function() { | ||
| var i, k, ref, results1; | ||
| results1 = []; | ||
| for (i = k = 0, ref = sqlite3_data_count(this.stmt); 0 <= ref ? k < ref : k > ref; i = 0 <= ref ? ++k : --k) { |
|
|
||
| Statement.prototype.bindFromArray = function(values) { | ||
| var k, len, num, value; | ||
| for (num = k = 0, len = values.length; k < len; num = ++k) { |
| values = this['get'](params); | ||
| names = this['getColumnNames'](); | ||
| rowObject = {}; | ||
| for (i = k = 0, len = names.length; k < len; i = ++k) { |
| Database.prototype['export'] = function() { | ||
| var _, binaryDb, ref, stmt; | ||
| ref = this.statements; | ||
| for (_ in ref) { |
| Database.prototype['close'] = function() { | ||
| var _, ref, stmt; | ||
| ref = this.statements; | ||
| for (_ in ref) { |
| wrapped_func = function(cx, argc, argv) { | ||
| var arg, args, data_func, i, k, ref, result, value_ptr, value_type; | ||
| args = []; | ||
| for (i = k = 0, ref = argc; 0 <= ref ? k <= ref : k >= ref; i = 0 <= ref ? ++k : --k) { |
| size = sqlite3_value_bytes(ptr); | ||
| blob_ptr = sqlite3_value_blob(ptr); | ||
| blob_arg = new Uint8Array(size); | ||
| for (j = l = 0, ref1 = size; 0 <= ref1 ? l < ref1 : l > ref1; j = 0 <= ref1 ? ++l : --l) { |
|
@rpellerin I'm guessing this would be easier to merge if all the different things you're fixing were separate PRs. |
|
Any update ? Can this be merged ? |
The travis tests are failing still, either they need to be updated or they need to pass as is. |
|
can this pull-request be closed as a duplicate of #349 ? |
Assertion failedthat occurred with the messageAssertion failed: you need to wait for the runtime to be ready (e.g. wait for main() to be called)