Skip to content

Fixed README example error #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Conversation

ALiangLiang
Copy link
Contributor

@ALiangLiang ALiangLiang commented Dec 15, 2019

The original code is not works. "this" points to a global variable (window or global)
ref:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions#No_separate_this

@lovasoa
Copy link
Member

lovasoa commented Dec 15, 2019

Thank you for the fix!

@lovasoa lovasoa merged commit 9303895 into sql-js:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants