Skip to content

fix the gh-pages submodule bad reference #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

restjohn
Copy link
Contributor

@restjohn restjohn commented Mar 6, 2020

simply git rm'ed the gh-pages dir to cease the error fatal: no submodule mapping found in .gitmodules for path 'gh-pages'; this will allow one to reference the git repo as an npm dependency again

…dule mapping found in .gitmodules for path 'gh-pages'`; this will allow one to reference the git repo as an npm dependency again
@lovasoa
Copy link
Member

lovasoa commented Mar 6, 2020

OK, thanks. Hopefully we can get the gh-pages working soon with #361

@lovasoa lovasoa merged commit 72b5dcd into sql-js:master Mar 6, 2020
@lovasoa
Copy link
Member

lovasoa commented Mar 6, 2020

However, please note that the git repo doesn't contain the compiled assets directly anymore (those are large binaries, which do not belong on the repo). So you won't be able to reference the repo directly in your package.json anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants