Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change swamp to multi-process mode #121

Merged
merged 3 commits into from
Dec 22, 2018
Merged

change swamp to multi-process mode #121

merged 3 commits into from
Dec 22, 2018

Conversation

yuyicg
Copy link
Contributor

@yuyicg yuyicg commented Dec 22, 2018

  1. change swamp to multi-process mode.
  2. add parameter --loss-sample-interval to make the multi-process loss curve graph more readable.

wangkuiyi
wangkuiyi approved these changes Dec 22, 2018
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Love this PR and learned to use multiprocessing.Manager. Thanks!

@wangkuiyi wangkuiyi merged commit 0b45a8f into develop Dec 22, 2018
@wangkuiyi wangkuiyi mentioned this pull request Dec 23, 2018
Closed
@yuyicg yuyicg deleted the swamp_multi_processes branch December 24, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

Assignees

@zou000 zou000

@wangkuiyi wangkuiyi

@skydoorkai skydoorkai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuyicg @wangkuiyi @zou000 @skydoorkai