Avoid duplicate import statements #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change it was possible to generate duplicate import statements.
Take this scheme:
{
"version": "1",
"packages": [{
"schema": "schema.sql",
"queries": "queries.sql",
"name": "queries",
"path": "."
}],
"overrides": [
{ "column": "toy.owner_id", "go_type": "database/sql.NullInt64" },
{ "column": "toy.manufacturer_id", "go_type": "database/sql.NullInt64" }
]
}
That would generate a `models.go` file with two imports for `database/sql`.
What the change here does is to make all imports, in the queries and the
models file, unique.
|
Thanks! This does have a slight problem in that import order could change, as map key iteration is randomized. I'm going to open a follow-up pull request that sorts the imports before returning them. |
|
Thanks for merging and doing the follow-up fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change it was possible to generate duplicate import statements.
Take this schema:
{ "version": "1", "packages": [{ "schema": "schema.sql", "queries": "queries.sql", "name": "queries", "path": "." }], "overrides": [ { "column": "toy.owner_id", "go_type": "database/sql.NullInt64" }, { "column": "toy.manufacturer_id", "go_type": "database/sql.NullInt64" } ] }That would generate a
models.gofile with two imports fordatabase/sql.What the change here does is to make all imports, in the queries and the
models file, unique.