Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test: Bump version to v1.17.2 in internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql #2108

Conversation

monkey-mas
Copy link
Contributor

Problem

go test ./... fails since an older sqlc version is set in the following auto-generated files.

internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v4/go/db.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v4/go/models.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v4/go/query.sql.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v5/go/db.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v5/go/models.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v5/go/query.sql.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/stdlib/go/db.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/stdlib/go/models.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/stdlib/go/query.sql.go

Solution

Re-generate those files by executing the command sqlc generate --experimental.

How to verify the change?

Run go test ./....

…lter_type_set_schema/postgresql

Problem
`go test ./...` fails since an older sqlc version is set in the following auto-generated files.

```
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v4/go/db.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v4/go/models.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v4/go/query.sql.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v5/go/db.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v5/go/models.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/pgx/v5/go/query.sql.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/stdlib/go/db.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/stdlib/go/models.go
internal/endtoend/testdata/ddl_alter_type_set_schema/postgresql/stdlib/go/query.sql.go
```

Solution
Regenerate thoes files by executing the command `sqlc generate --experimental`.

How to verify the change?
Run `go test ./...`.
@monkey-mas
Copy link
Contributor Author

monkey-mas commented Feb 24, 2023

FYI, the related PR(#2027) was merged without rebase after v1.17.2 had been released.

@kyleconroy kyleconroy merged commit 8f0389e into sqlc-dev:main Feb 24, 2023
@monkey-mas monkey-mas deleted the bump-to-sqlc-v1.17.2-ddl_alter_type_set_schema-postgres branch February 24, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants