fix(vet): Split vet messages out of codegen.proto #2511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmbenton
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
This looks nice.
I'm just realizing though that I don't think the cel.Types() call is doing anything, or at least doesn't seem to be required?
Nothing else in the vet codepath references PostgreSQLExplain and MySQLExplain although they are types of fields on vet.PostgreSQL and vet.MySQL.
I guess if that call to cel.Types() isn't required we can remove it in a separate PR.
|
Okay I think this is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll move it back into the codegen package once we're ready for vet WASM plugins.