Improve table catalog lookups #2857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents rangeVars (now rawRangeTblRefs) from descending into subqueries, which caused it to look at table references not in this query's scope. It also renames this function and makes it extract all relevant table definition AST nodes instead of just RangeVars. It then passes these to resolveCatalogRefs. resolveCatalgoRefs now also rejects attempts to use sqlc.embed with ad-hoc-defined tables (function outputs and subqueries) as their outputs do not have corresponding model types. Previously this generated broken code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents rangeVars (now rawRangeTblRefs) from descending into subqueries, which caused it to look at table references not in this query's scope.
It also renames this function and makes it extract all relevant table definition AST nodes instead of just RangeVars. It then passes these to resolveCatalogRefs.
resolveCatalgoRefs now also rejects attempts to use sqlc.embed with ad-hoc-defined tables (function outputs and subqueries) as their outputs do not have corresponding model types. Previously this generated broken code.