Implement record/replay testing #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing tests in `gen_test` were unit tests that tested internal APIs. Port these tests to integration tests, encompassing an entire run of sqlc itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nelson Elhage wrote a fantastic blog post about Record/Replay testing in Sorbert, a type-checker for Ruby programs. The post details their testing setup which involves testing the compile as a black box. Run it against a set of inputs and compare the output to a known set of expected outputs.
We already do this to make sure that the examples directory is up to date. I've updated the end-to-end package to make these types of tests easy to write. I also ported
gen_testover to the new framework.The biggest improvement is that the tests and command-line tool now call into the same function,
cmd.Generate. This ensures that we're testing exactly what is being called by thesqlcbinary.