Support multi-line SQL comments #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-line SQL comments broke the code generator. This PR fixes the issue.
The case: Consider this SQL schema:
Previous behavior: The code generator (
sqlc generate
) exited with an error:The reason is obvious: The code generator adds
//
only at the beginning of the comment string. As a result, only the first line of the comment string is commented out.New behavior: Code generator adds
//
at the beginning of every line of the comment string. For the aforementioned schema, themodels.go
file will be generated as:The fix:
go fmt
'd usinggo1.13.4 linux/amd64
.