Skip to content

internal/dinosql: support Postgres macaddr type in Go #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2020
Merged

internal/dinosql: support Postgres macaddr type in Go #358

merged 1 commit into from
Feb 24, 2020

Conversation

kevinburke1
Copy link
Contributor

Tests not passing, just wanted to submit

@kevinburke1 kevinburke1 changed the title WIP Macaddr internal/dinosql: support Postgres macaddr type in Go Feb 24, 2020
kyleconroy
kyleconroy requested changes Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a separate test instead of adding columns to the ondeck example?

@kevinburke1
Copy link
Contributor Author

ok added

@kyleconroy kyleconroy merged commit d2823f5 into sqlc-dev:master Feb 24, 2020
@kevinburke1 kevinburke1 deleted the macaddr branch February 24, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinburke1 @kyleconroy