Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special case for "campus" #435

Merged
merged 2 commits into from
Apr 5, 2020
Merged

Add special case for "campus" #435

merged 2 commits into from
Apr 5, 2020

Conversation

kyleconroy
Copy link
Collaborator

The new inflection package wraps https://github.com/jinzhu/inflection, but fixes the incorrect handling of "campus".

I also changed the call order of Singular and StructName. While this may cause some code to change, it allows users to use the rename feature to fix future pluralization issues without needing to patch sqlc.

Fixes #430

I reported the bug upstream jinzhu/inflection#13

@kyleconroy kyleconroy changed the title Add special for "campus" Add special case for "campus" Apr 5, 2020
@kyleconroy kyleconroy merged commit 8e90d42 into master Apr 5, 2020
@kyleconroy kyleconroy deleted the singular branch April 5, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singular Table Name Ending with "s"
1 participant