Fix unused imports for Go code generator #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ":cmd" queries, the return type should not be imported.
Tests the patch for unused imports.
soroushj
changed the title
|
👏 👏 👏 Thank you for: a) an amazing bug report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721.
Essentially, I've changed the condition for importing return types (and imports required for their scanning) from
!q.Ret.isEmpty()toq.Cmd != ":exec" && !q.Ret.isEmpty().I've also added a new end-to-end test that fails without this patch.
P.S. I didn't test the Kotlin code generator, but probably it has the same issue (see here and here). But since unused imports are not a compile error in Kotlin, it's not a big issue anyway.