Skip to content

fix: can't open setting when no database be selected #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

CorrectRoadH
Copy link
Contributor

@CorrectRoadH CorrectRoadH commented Jun 1, 2023

What does the PR do?

delete incorrect side Effect dependent🤔 otherwise it will rerender stopless and cause can't open the setting page when no database is selected

@vercel
Copy link

vercel bot commented Jun 1, 2023

@CorrectRoadH is attempting to deploy a commit to the bytebase Team on Vercel.

A member of the Team first needs to authorize it.

@CorrectRoadH CorrectRoadH changed the title fix: can't open setting when SQL be selected fix: can't open setting when no database be selected Jun 1, 2023
@CorrectRoadH CorrectRoadH marked this pull request as draft June 1, 2023 11:04
@CorrectRoadH CorrectRoadH force-pushed the fix/can't_open_setting branch from 740797f to 207b9f2 Compare June 1, 2023 11:07
@CorrectRoadH CorrectRoadH marked this pull request as ready for review June 1, 2023 11:10
Copy link
Member

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianzhou tianzhou merged commit 59e7fea into sqlchat:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants