Always copy to clipboard and to internal buffer. Embedded image support. #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support At the time of pasting, use the generator and date meta tags in the HTML version for knowing whether our data in the system clipboard has been overwritten. If not, the internal buffer has better data, so we use it. Since the binary data is not excluded in the system clipboard, images are also included embedded in the HTML table. Other binary data are encoded as base64 strings.
# Conflicts: # src/ExtendedTableWidget.cpp
# Conflicts: # src/ExtendedTableWidget.cpp
MKleusberg
approved these changes
Dec 22, 2017
| } else { | ||
| QByteArray text; | ||
| if (m->isBinary(index)) | ||
| text = data.toByteArray().toBase64(); // TODO: Or should be just "BLOB"? |
There was a problem hiding this comment.
I would probably leave them empty like we did before. So no "Image" and no "BLOB" but no data either if that makes sense. The reason is that probably no one will parse the Base64 when pasting anyway. And because it's impossible to tell if the contents of a cell was actual binary data, "BLOB", or some Base64 string I think it's best to just not copy anything. It's probably the clearest way to tell the user that this isn't going to work as expected 😉
There was a problem hiding this comment.
Great! That isn't really very useful and my TODO note was already indicating my hesitation. No objection at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of pasting, use the generator and date meta tags in the HTML
version for knowing whether our data in the system clipboard has been
overwritten. If not, the internal buffer has better data, so we use it.
Since the binary data is not excluded in the system clipboard, images
are also included embedded in the HTML table. Other binary data are encoded
as base64 strings.
See issue #1244