Fix for Oracle insert many #557
Conversation
| @@ -17,6 +17,11 @@ public partial class Compiler | |||
| protected virtual string LastId { get; set; } = ""; | |||
| protected virtual string EscapeCharacter { get; set; } = "\\"; | |||
|
|
|||
|
|
|||
| protected virtual string SingleInsertStartClause { get; set; } = "INSERT INTO"; | |||
There was a problem hiding this comment.
I think this is the case for Oracle only, I prefer removing it from the global compiler, unless it's really needed
There was a problem hiding this comment.
Currently "INSERT INTO" is harcoded (around line 400) for global compiler.
Using SingleInsertStartClause by @mathijs-dumon doesn't make things worse for sure, although I can't judge if it's actually the best way. However, this PR is very important to fix the problem.
|
@mattewre @ahmad-moussawi |
|
Hey Ahmad, I love your package and it's working great for me so far. I found this Oracle INSERT MANY issue while working with this compiler in particular and it looks like this merge is going to fix the issue. I was wondering if there is any timeline on the next release for SqlKata, that will include this merged Oracle Compiler change! Thank you! |
This is a replacement PR for this older branch: issue-192
I compared the test case that was in the old branch, my tests are equivalent.
The generated SQL is slightly different, (INSERT ALL vs UNION ALL) but functionally equivalent. The INSERT ALL approach is more in line with what other dialects do.
This fixes #192