Support multiple jwt audiences for oidc #977
Merged
+63
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: contact <contact@ophir.dev>
Co-authored-by: contact <contact@ophir.dev>
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no bugs!
Bugbot free trial expires on August 9, 2025
Learn more in the Cursor dashboard.
The changes move audience verification into a dedicated type and improve code organization around ID token verification.
Add OIDC config comments and improve array syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow OIDC JWTs to contain multiple audiences to improve compatibility with various providers (e.g., ZITADEL, Azure AD).
Previously, SQLPage's OIDC validation strictly expected only the client ID in the
audclaim. However, many OIDC providers include additional audiences, leading to "Invalid audiences" errors (GitHub issue #965). This PR leveragesopenidconnect'sset_other_audience_verifier_fnto allow flexible audience validation, defaulting to a permissive mode that accepts additional audiences as long as the client ID is present, while also offering configurable strictness viaoidc_additional_trusted_audiences.Open in Web • Open in Cursor • Open Docs