Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Drop Android Manifest Maven Plugin #95

Closed
JakeWharton opened this issue Nov 8, 2012 · 2 comments · Fixed by #204
Closed

Drop Android Manifest Maven Plugin #95

JakeWharton opened this issue Nov 8, 2012 · 2 comments · Fixed by #204
Assignees
@JakeWharton

Comments

@JakeWharton
Copy link
Collaborator

No description provided.

@ghost ghost assigned JakeWharton Nov 8, 2012
@swankjesse
Copy link
Contributor

Let's just drop this.

@cgruber
Copy link
Collaborator

cgruber commented Apr 11, 2013

Abstain for lack of really strong connection to it one way or the other.
No objections though, if it's not providing enough value.

@JakeWharton JakeWharton mentioned this issue Apr 11, 2013
Merged
tbroyer pushed a commit to tbroyer/dagger that referenced this issue Jan 21, 2016
@ronshapiro @cgruber
Only omit @generated if javax.annotation.Generated is on the compile-…
c4bd8bf 
…time classpath.

See Github Issue square#95 for users that get stuck when compiling for Android and their build fails because the annotation is not present.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=109933503
tbroyer pushed a commit to tbroyer/dagger that referenced this issue Jan 21, 2016
@cgruber
Automated g4 rollback of changelist 109933503.
fa3ce1e 
*** Reason for rollback ***

Lots of down-stream compilation failures in continuous integration.

*** Original change description ***

Only omit @generated if javax.annotation.Generated is on the compile-time classpath.

See Github Issue square#95 for users that get stuck when compiling for Android and their build fails because the annotation is not present.

***

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=109941410
tbroyer pushed a commit to tbroyer/dagger that referenced this issue Jan 21, 2016
@ronshapiro @cgruber
Omit @generated if javax.annotation.Generated is not on the compile-t…
0488c9d 
…ime classpath.

See Github Issue square#95 for users that get stuck when compiling for Android and their build fails because the annotation is not present.

***

Rollforward of a prior commit.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=110258324
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JakeWharton JakeWharton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Android manifest plugin. square/dagger
3 participants
@JakeWharton @swankjesse @cgruber