Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PonyDebugger causing modals to dismiss without animation #35

Closed
adamhowardprice opened this issue Dec 6, 2012 · 5 comments
Closed

PonyDebugger causing modals to dismiss without animation #35

adamhowardprice opened this issue Dec 6, 2012 · 5 comments
Labels

Comments

@adamhowardprice
Copy link

I've found an issue with all modals in my app that are being dismissed with [self dismissModalViewControllerAnimated:YES completion:nil];

When I have PonyDebugger enabled, every modal dismisses without animation. When I turn it off, the modals dismiss with animation like normal.

@ryanolsonk
Copy link
Contributor

Do you have PonyDebugger's view hierarchy debugging enabled?

@adamhowardprice
Copy link
Author

Yes

@adamhowardprice
Copy link
Author

Commenting out the line
[debugger enableViewHierarchyDebugging];
also fixes the modal animation.

@wlue
Copy link
Contributor

wlue commented Dec 10, 2012

I've had this issue as well. It only happens with default modal animations (the horizontal flip modal animation still works).

@ryanolsonk
Copy link
Contributor

Good catch! I made a mistake in the swizzled exchangeSubviewAtIndex:withSubviewAtIndex: which was responsible. I will open a pull request later tonight.

Reminds me of one of my favourite Cocoa selector names (from UIViewController):

attentionClassDumpUser:yesItsUsAgain:althoughSwizzlingAndOverridingPrivateMethodsIsFun:itWasntMuchFunWhenYourAppStoppedWorking:pleaseRefrainFromDoingSoInTheFutureOkayThanksBye:

wlue added a commit that referenced this issue Dec 12, 2012
@wlue wlue closed this as completed Dec 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants