Allow dynamic injection of credentials #55
Merged
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcapulet
force-pushed
the
alexc-dynamic-injection
branch
2 times, most recently
from
4e8ff77 to
3b023ff
Compare
baweaver
reviewed
Jun 6, 2019
| env[Rails::Auth::Env::CREDENTIALS_ENV_KEY] = @credentials | ||
| (@credentials.respond_to?(:call) ? @credentials.call(env) : @credentials).tap do |credentials| | ||
| env[Rails::Auth::Env::CREDENTIALS_ENV_KEY] = credentials | ||
| end |
There was a problem hiding this comment.
tap might be a bit overkill here.
credentials = @credentials.respond_to?(:call) ? @credentials.call(env) : @credentials
env[Rails::Auth::Env::CREDENTIALS_ENV_KEY] = credentials
@app.call(env)
nerdrew
approved these changes
Jun 7, 2019
drcapulet
force-pushed
the
alexc-dynamic-injection
branch
from
3b023ff to
8c9f1bc
Compare
|
|
drcapulet
force-pushed
the
alexc-dynamic-injection
branch
from
8c9f1bc to
bc10c1a
Compare
baweaver
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.