Skip to content

Remove ca_file and require_cert options to the config builder as we no longer verify the certificate chain #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Remove ca_file and require_cert options to the config builder as we no longer verify the certificate chain #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
### Unreleased

* [#68](https://github.com/square/rails-auth/pull/68)
Remove `ca_file` and `require_cert` options to the config builder as we no
longer verify the certificate chain.
([@drcapulet])

* [#67](https://github.com/square/rails-auth/pull/67)
Remove `ca_file`, `require_cert`, and `truststore` options to X509 middleware
as we no longer verify the certificate chain.
Expand Down
7 changes: 0 additions & 7 deletions lib/rails/auth/config_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,22 +31,15 @@ def test(config)
def production(
config,
cert_filters: nil,
require_cert: false,
ca_file: nil,
error_page: Rails.root.join("public/403.html"),
monitor: nil
)
raise ArgumentError, "no cert_filters given but require_cert is true" if require_cert && !cert_filters
raise ArgumentError, "no ca_file given but cert_filters were set" if cert_filters && !ca_file

error_page_middleware(config, error_page)

if cert_filters
config.middleware.insert_before Rails::Auth::ACL::Middleware,
Rails::Auth::X509::Middleware,
require_cert: require_cert,
cert_filters: cert_filters,
ca_file: ca_file,
logger: Rails.logger
end

Expand Down