Clean Up Actions and Remove JMH Benchmarks #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
steve-the-edwards
changed the base branch from
main
to
sedwards/985-state-compare
steve-the-edwards
force-pushed
the
sedwards/clean-up-actions
branch
2 times, most recently
from
6ecb869 to
63798f8
Compare
steve-the-edwards
force-pushed
the
sedwards/985-state-compare
branch
from
2db3e12 to
eefa11e
Compare
RBusarow
approved these changes
Jun 9, 2023
Comment on lines
-18
to
-38
| compilations { | ||
| val main by getting | ||
|
|
||
| create("workflowNode") { | ||
| val workflowNodeCompilation: KotlinJvmCompilation = this | ||
| kotlinOptions { | ||
| // Associating compilations allows us to access declarations with `internal` visibility. | ||
| // It's the new version of the "-Xfriend-paths=___" compiler argument. | ||
| // https://youtrack.jetbrains.com/issue/KTIJ-7662/IDE-support-internal-visibility-introduced-by-associated-compilations | ||
| workflowNodeCompilation.associateWith(main) | ||
| } | ||
| defaultSourceSet { | ||
| dependencies { | ||
| implementation(libs.kotlinx.benchmark.runtime) | ||
|
|
||
| implementation(main.compileDependencyFiles + main.output.classesDirs) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
steve-the-edwards
force-pushed
the
sedwards/985-state-compare
branch
from
eefa11e to
19d02fc
Compare
Closes #998. These are not being run.
steve-the-edwards
force-pushed
the
sedwards/clean-up-actions
branch
from
63798f8 to
52e0632
Compare
rjrjr
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #998 , and #1010 .
Renames shards that were previously ambiguous regarding runtimes.