Introduces TextController.asMutableState. #557
Conversation
...les/compose-samples/src/main/java/com/squareup/sample/compose/textinput/TextInputWorkflow.kt
Show resolved
Hide resolved
...w-ui/compose/src/main/java/com/squareup/workflow1/ui/compose/TextControllerAsMutableState.kt
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/compose-textcontroller
branch
from
6c6af33 to
6fc28de
Compare
| return remember { mutableStateOf("") }.also { state -> | ||
| // Restart the effect if a different controller is passed in. | ||
| LaunchedEffect(this) { | ||
| state.value = textValue |
There was a problem hiding this comment.
This won't run until after the first composition for the given text controller, which means you'll always get a frame with blank text. You need to initialize the state in the composition, ie when you create the mutable state. I did it that way in the snippet for a reason. You should probably also pass the text controller as a key to remember so it's immediately updated if the controller changes as well.
There was a problem hiding this comment.
I refuse to admit how hard I looked for a version of remember that took a key without finding it four lines down. Remember kids, it's important to get a full night's sleep.
rjrjr
force-pushed
the
ray/compose-textcontroller
branch
2 times, most recently
from
b91f8aa to
5421ff6
Compare
|
@laurakelly @maybeYouShouldBeTheLawyer @helios175 You're probably interested in this. |
Co-authored-by: Ray Ryan <ray@squareup.com>
rjrjr
force-pushed
the
ray/compose-textcontroller
branch
from
5421ff6 to
270d11f
Compare
|
Flakiness tracked at #559, not related to this PR. |
Uh oh!
There was an error while loading. Please reload this page.