Skip to content

Conversation

RBusarow
Copy link
Contributor

Note @rjrjr that we'll need to change the ui branch's version to something like 1.7.0-ui-SNAPSHOT in order to avoid overwrites.

@RBusarow RBusarow requested review from a team and zach-klippenstein as code owners February 22, 2022 20:09
@RBusarow RBusarow added the build label Feb 22, 2022
@RBusarow RBusarow changed the title auto-publish a snapshot after merging to main or ray/ui-update auto-publish a snapshot after pushing to main or ray/ui-update Feb 22, 2022
Copy link
Contributor

@steve-the-edwards steve-the-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rjrjr
Copy link
Collaborator

rjrjr commented Feb 22, 2022

Note @rjrjr that we'll need to change the ui branch's version to something like 1.7.0-ui-SNAPSHOT in order to avoid overwrites.

I was planning on something like 1.7.0-uiUpdate01-SNAPSHOT.

Do you want to go ahead and do that in this PR? Wow, that was dumb.

@rjrjr
Copy link
Collaborator

rjrjr commented Feb 22, 2022

Note @rjrjr that we'll need to change the ui branch's version to something like 1.7.0-ui-SNAPSHOT in order to avoid overwrites.

I was planning on something like 1.7.0-uiUpdate01-SNAPSHOT.

Do you want to go ahead and do that in this PR? Wow, that was dumb.

#679

@RBusarow RBusarow force-pushed the rick/auto-publish_snapshots branch from 77488d1 to 2af4ad3 Compare February 22, 2022 21:41
@RBusarow RBusarow merged commit 2f22ec7 into main Feb 22, 2022
@RBusarow RBusarow deleted the rick/auto-publish_snapshots branch February 22, 2022 22:37
java-version: 11.0.7

- name : Publish Snapshots
run: ./gradlew clean build && ./gradlew publish --no-parallel --no-daemon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need --no-daemon on both sides?

        run: ./gradlew clean build --no-daemon && ./gradlew publish --no-parallel --no-daemon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. They're totally different commands thanks to &&.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ 🤦 I was on my phone and read that backwards. It's not a huge deal but yes I'll make an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants