AsyncSequenceWorker’s should not throw errors #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added catch for errors in AsyncSequenceWorker.
amorde
reviewed
Jun 30, 2025
| sink.send(AnyWorkflowAction(sendingOutput: output)) | ||
| } | ||
| } catch { | ||
| fatalError("AsyncSequenceWorker implementations should not throw errors on iteration: \(error)") |
There was a problem hiding this comment.
would it be possible to add where Sequence.Failure == Never to the associatedtype declaration to codify that we expect a worker's run function to return a sequence that never fails?
There was a problem hiding this comment.
No because Failure is iOS 18+ on AsyncSequence. We did try that.
There was a problem hiding this comment.
ugh. that sucks. saw the comment about the any AsyncSequence<Element, Failure> but thought maybe that was something else
amorde
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added catch for errors in AsyncSequenceWorker.
Checklist