Skip to content

Introduce 'makeOutputSink' convenience on 'RenderContext' #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2020
Merged

Introduce 'makeOutputSink' convenience on 'RenderContext' #55

merged 1 commit into from
Aug 21, 2020

Conversation

mattfaluotico
Copy link
Collaborator

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bencochran
bencochran requested changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@bencochran bencochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

dhavalshreyas
dhavalshreyas approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@dhavalshreyas dhavalshreyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yayy! Thank you!

bencochran
bencochran approved these changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@bencochran bencochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Ready to take off the [WIP] and we can merge this, or are you planning anything else here?

@mattfaluotico mattfaluotico changed the title [WIP] Introduce 'makeOutputSink' convenience on 'RenderContext' Introduce 'makeOutputSink' convenience on 'RenderContext' Aug 20, 2020
@mattfaluotico
Copy link
Collaborator Author

Just removed the WIP. Wanted to make sure everyone liked the naming and such. It's good to go.

@mattfaluotico mattfaluotico merged commit cccd720 into square:main Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencochran bencochran bencochran approved these changes

+1 more reviewer

@dhavalshreyas dhavalshreyas dhavalshreyas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattfaluotico @CLAassistant @bencochran @dhavalshreyas