Skip to content

Remove deprecated rendered(with:key:) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Remove deprecated rendered(with:key:) #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions MigrationGuide_v1.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@

`context.awaitResult` was deprecated in Workflow v1.0α and has been removed in the beta. See details in the alpha migration guide, [below](#run-worker).

### Child `Workflow`s

`Workflow.rendered(with:key:)` was deprecated in Workflow v1.0α and has been removed in the beta. See details in the alpha migration guide, [below](#render-child-workflow).

---

# Workflow v1.0α Migration Guide
Expand Down
21 changes: 1 addition & 20 deletions Workflow/Sources/AnyWorkflowConvertible.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,26 +84,7 @@ extension AnyWorkflowConvertible where Rendering == Void, Output: WorkflowAction
}
}

// MARK: - Deprecated

extension AnyWorkflowConvertible {
@available(*, deprecated, renamed: "rendered(in:key:)")
public func rendered<Parent>(with context: RenderContext<Parent>, key: String = "") -> Rendering where Output: WorkflowAction, Output.WorkflowType == Parent {
return rendered(in: context, key: key)
}

@available(*, deprecated, renamed: "rendered(in:key:)")
public func rendered<Parent>(with context: RenderContext<Parent>, key: String = "") -> Rendering where Output == AnyWorkflowAction<Parent> {
return rendered(in: context, key: key)
}
}

extension AnyWorkflowConvertible where Output == Never {
@available(*, deprecated, renamed: "rendered(in:key:)")
public func rendered<T>(with context: RenderContext<T>, key: String = "") -> Rendering {
return rendered(in: context, key: key)
}
}
// MARK: -

extension AnyWorkflowConvertible {
/// Process an `Output`
Expand Down