Skip to content

Make RenderContext.render(workflow:key:outputMap:) internal #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2020
Merged

Make RenderContext.render(workflow:key:outputMap:) internal #65

merged 2 commits into from
Sep 10, 2020

Conversation

AquaGeek
Copy link
Collaborator

@AquaGeek AquaGeek commented Sep 10, 2020 •
edited
Loading

This method was accidentally marked public a while back.

I think we have 3 usages of it (internally) that we'll need to migrate.

Checklist

  • Unit Tests
  • I have made corresponding changes to the documentation

@AquaGeek AquaGeek added this to the v1.0.0 beta milestone Sep 10, 2020
@AquaGeek AquaGeek force-pushed the stromberg/gardening/render-workflow branch from 21cb879 to 1739807 Compare September 10, 2020 21:35
@AquaGeek AquaGeek merged commit 3abadd3 into main Sep 10, 2020
@AquaGeek AquaGeek deleted the stromberg/gardening/render-workflow branch September 10, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencochran bencochran bencochran approved these changes

@JustinDSN JustinDSN Awaiting requested review from JustinDSN

+1 more reviewer

@dhavalshreyas dhavalshreyas dhavalshreyas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0 beta
Development

Successfully merging this pull request may close these issues.
3 participants
@AquaGeek @bencochran @dhavalshreyas