Add helper method to ignore output #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This is great! We'd also need a counter-part API on the |
watt
commented
Mar 4, 2021
| /// - key: The key of the expected workflow (if specified). | ||
| /// - rendering: The rendering result that should be returned when the workflow of this type is rendered. | ||
| /// - assertions: Additional assertions for the given workflow, if any. You may use this to assert the properties of the requested workflow are as expected. | ||
| public func expectWorkflowIgnoringOutput<ExpectedWorkflowType: Workflow>( |
There was a problem hiding this comment.
@dhavalshreyas Is this in line with what you had in mind?
dhavalshreyas
approved these changes
Mar 4, 2021
| /// - key: The key of the expected workflow (if specified). | ||
| /// - rendering: The rendering result that should be returned when the workflow of this type is rendered. | ||
| /// - assertions: Additional assertions for the given workflow, if any. You may use this to assert the properties of the requested workflow are as expected. | ||
| public func expectWorkflowIgnoringOutput<ExpectedWorkflowType: Workflow>( |
|
Thanks @watt, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a helper method to
AnyWorkflowConvertibleto ignore outputs.I'm not sure if this is testable, but happy to add tests if someone has an idea how!
Checklist