Recreated demo project.

[benjohnde]

A bit of restructuring and got the demo project back to work. Reformatted some comments to work with recent Xcode. Closes #33.

Sry for the huge amount of changes. I recreated the whole demo project and cleaned it up (especially removed localization shizzle and all the AppDelegate stubs to focus only on the actual example invocation of the DatePickerDialog).

I also created a shared scheme for the DatePickerDialog itself. Now you have all three parts (Sources, Tests and Demo) in one Xcode project. It is also more feasible to write unit tests and directly see the changes in the demo application.

Cheers!

[lfarah]

Hey @benjohnde, I downloaded your branch and got this:

[benjohnde]

I guess you need to select the framework scheme at first and build it.
Maybe we should put that in the readme. If it does not work out for you I
will look into it later on.

Am 19.09.2016 10:03 vorm. schrieb "Lucas Farah" notifications@github.com:

Hey @benjohnde https://github.com/benjohnde, I downloaded your branch
and got this:
[image: screen shot 2016-09-19 at 1 02 45 am]
https://cloud.githubusercontent.com/assets/6511079/18625654/d62c0574-7e04-11e6-8c7c-c897254fda86.png

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFMBQowyHRt3PDMYkyjSfAuB7FTYnXv2ks5qrkHVgaJpZM4KABvG
.

[lfarah]

Now it worked. What if instead of making the framework necessary for the example app, we just add the DatePickerDialog.swift into the Example project?

[lfarah]

Again, really thanks for helping the lib! 😄

[benjohnde]

I really hate that because changing the library means copying the file into
the demo project. For me it feels like a much cleaner approach to build the
framework and the run the example project. Maybe we can create a symbolic
link but also feels a bit hacky :D

Am 19.09.2016 10:24 vorm. schrieb "Lucas Farah" notifications@github.com:

Now it worked. What if instead of making the framework necessary for the
example app, we just add the DatePickerDialog.swift into the Example
project?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFMBQo9XOf5khSNl832q7HR6Pz6r6O3gks5qrkapgaJpZM4KABvG
.

[lfarah]

@benjohnde I completely understand your point of view. I think that there are many developers that wouldn't know what building the framework scheme is, so by providing an example app that just works is very important for beginners.
On my libs, I always drag the file and remain this unchecked, so we don't have to copy the file every single time:

[benjohnde]

True. Maybe we can create a hard dependency so that the framework gets
built automatically beforehand. I will dig into that.

Am 19.09.2016 10:29 vorm. schrieb "Lucas Farah" notifications@github.com:

@benjohnde https://github.com/benjohnde I completely understand your
point of view. I think that there are many developers that wouldn't know
what building the framework scheme is, so by providing an example app that just
works is very important for beginners.
On my libs, I always drag the file and remain this unchecked, so we don't
have to copy the file every single time:
[image: screen shot 2016-09-19 at 1 28 30 am]
https://cloud.githubusercontent.com/assets/6511079/18626211/6ea43a44-7e08-11e6-80f0-f284d7e7ab60.png

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFMBQv_qWvLERhX0g1M5mWN6AdGdVkABks5qrkfhgaJpZM4KABvG
.

[benjohnde]

Now it should work like magic :) I only missed to add the framework to "Linked Frameworks and Libraries" as "required" in the demo target. You can verify it by doing the following:

• Select the framework scheme, clean the build.
• Then remove the entry in "Linked Frameworks and Libraries" from the demo target.
• Now try to build the demo project -> it should break.
• Add the entry again -> try to build the demo project -> should work as intended.

Cheers!

[lfarah]

Perfect! Merging this, bumping the version and sending to CocoaPods 👍

[lfarah]

Hey @benjohnde, I'm having problems with CocoaPods

[benjohnde]

Hey @lfarah I am not familiar with CocoaPods. I will give Carthage a try later on. But your bug report does not sound like it could be our fault.

[lfarah]

It's working now...