Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results seem to be in reverse order #14

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Conversation

walseb
Copy link
Contributor

@walseb walseb commented Oct 30, 2018

The search results seem to be in the reverse order
You can see that the results are more accurate in the second screenshot
The only downside to this is that the first entry will be a nil because of some bug that I will create a issue on later (it's present in all ivy-youtube versions, but it's normally pretty well hidden at the bottom).
This is identical on pretty much every version of ivy-youtube (initial commit, before my recent changes, master)
I'm using emacs -q here

ivy-youtube-filter
Before reversing order
ivy-youtube-not-reversed
After reversing order
ivy-youtube-filter2

I will admit that the solution is kind of hacky though hah

@squiter
Copy link
Owner

squiter commented Oct 30, 2018

This PR will expose the #15 to all users... maybe we can wait to fix the issue before merge this? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants