Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squiz/SemicolonSpacing: improve handling of semicolons in for control structures #1691

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Squiz/SemicolonSpacing: improve handling of semicolons in for control structures #1691

merged 1 commit into from
Oct 26, 2017

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Oct 8, 2017

This is a solution for issue #1690 in which I've basically implemented the first of the three options mentioned in the issue.

Selectively exclude semi-colons found within a for() condition when they are preceded by the open parenthesis or by another ;.

Includes unit tests.

Fixes #1690

@gsherwood gsherwood added this to the 3.2.0 milestone Oct 8, 2017
This was referenced Oct 9, 2017
Closed
Closed
@gsherwood
Copy link
Member

Thanks for doing this.

@gsherwood gsherwood merged commit db035fa into squizlabs:master Oct 26, 2017
gsherwood added a commit that referenced this pull request Oct 26, 2017
@gsherwood
Changelog for #1691
ea8df91
@jrfnl jrfnl deleted the feature/issue-1690-semicolon-whitespace branch October 27, 2017 00:20
This was referenced Dec 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jrfnl @gsherwood