Generic/DocComment: bug fix - don't remove ignore annotations when fixing #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xing The code sample included in the tests would previously result in an "There must be a single blank line after a tag group" error, even though there _is_ a blank line after the `@codeCoverageIgnore` tag. The auto-fixer would subsequently fix this by removing the `@phpcs:disable` comment + the blank line after it. Fixed now. Includes test.
fredden
approved these changes
Sep 25, 2023
jrfnl
added a commit
to Yoast/whip
that referenced
this pull request
Sep 26, 2023
Align parameter descriptions in docblocks and other minor formatting fixes. Note: there is one more to fix, but this is waiting on a [bug fix in PHPCS](squizlabs/PHP_CodeSniffer#3893) (bug discovered when making this change).
1 task
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#91 |
jrfnl
deleted the
feature/generic-doccomment-fixer-removes-ignore-annotations
branch
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code sample included in the tests would previously result in an "There must be a single blank line after a tag group" error, even though there is a blank line after the
@codeCoverageIgnoretag.The auto-fixer would subsequently fix this by removing the
@phpcs:disablecomment + the blank line after it.Fixed now.
Includes test.
Suggested changelog entry
Types of changes