added physical-to-logical path mapping command-line option #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nfsaavedra
requested changes
May 1, 2025
There was a problem hiding this comment.
Hi @ali-ghanbari! Thanks for your interest in our tool and for the contribution! Overall the code LGTM, however there are two issues:
- The linter step of the CI is failing. Please use black to format the files so this step does not fail.
- The tests are failing. I think all the failures are related to the same problem. You can see the logs here. I had to cancel these jobs because they wouldn't finish. I think one process is hanging due to the errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for creating this extremely useful tool.
During my experiments with CoqPyt, I realized that I cannot pass physical-to-logical path mapping options (-Q/-R) to Coq-LSP.
I have added an (optional) extra parameter for some of the classes to accept extra parameters from the client code.
Let me know if you need further clarification/refactoring.